Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Header link to categories list use wrong url (slug generation problem) #365

Closed
blackgearit opened this issue Feb 6, 2020 · 2 comments · Fixed by #366
Closed

[BUG] Header link to categories list use wrong url (slug generation problem) #365

blackgearit opened this issue Feb 6, 2020 · 2 comments · Fixed by #366
Assignees
Labels
bug Something isn't working

Comments

@blackgearit
Copy link

Describe the bug
When categories in Shopware has complex names (like the one contained into demo data "Free time & Electronics) the header uses wrong slug to request the page data ('free-time \u0026 electronics')

How to reproduce
Create a complex Category in Shopware 6 or use demo data

Expected behavior
Same slug as one used by Shopware 6

Actual behavior
404 page not found from API

Code examples
the body of the request to the Shopware 6 API:

{path: "free-time & electronics/", associations: {options: {associations: {group: {}}}}}

the response from the api:

{"errors":[{"code":"0","status":"404","title":"Not Found","detail":"Path `free-time \u0026 electronics\/` could not be resolved."}]}

Screenshots

Devices (please complete the following information):
All

NB: with a simpler category name like "clothing", all works.

@blackgearit blackgearit added the bug Something isn't working label Feb 6, 2020
@rmakara
Copy link
Collaborator

rmakara commented Feb 6, 2020

Thank you for the issue @blackgearit. We will discuss that with the team today. 👍

@mkucmus
Copy link
Collaborator

mkucmus commented Feb 6, 2020

Will be solved with the point 2. from #271. We won't be using the our slugifier, because it's not compatible with logic which shopware does (https://github.com/cocur/slugify).

we can consider using the technical ones in the entire application until the #271 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants