Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]CMS components - Block 'Images' - the pictures are not shown in the right places #426

Closed
akrajna opened this issue Feb 21, 2020 · 4 comments · Fixed by #500 or #573
Closed

[BUG]CMS components - Block 'Images' - the pictures are not shown in the right places #426

akrajna opened this issue Feb 21, 2020 · 4 comments · Fixed by #500 or #573
Assignees
Labels
bug Something isn't working CMS components

Comments

@akrajna
Copy link
Collaborator

akrajna commented Feb 21, 2020

Describe the bug
Block category 'Images' - the pictures are not shown in the right places. Doesn't matter if you choose 'Three columns, rounded' block or 'Image grid' block the pictures are shown one after another, not rounded and not in grid

How to reproduce

Steps to reproduce the behavior:

  1. Go to 'categories' from Shopware
  2. Select 'Clothing'-'Movies & Toys' from category structure
  3. Go to 'Layout assignment'
  4. Click 'Edit in designer' button
  5. Click 'Settings' icon
  6. Click 'block' icon
  7. Select block category 'Images'
  8. Add 'Two columns, boxed', 'Three columns, boxed', 'Three columns, full-sized',' Four columns, boxed', 'Three columns, rounded', 'Three columns, boxed & background', 'Image grid'
  9. Hover on each image, click 'setting' icon and upload picture
  10. Click 'Save' button in the upper right corner
  11. Go to subcategory 'Movies & Toys' on our website
  12. See the error

Expected behavior
Pictures should be displayed in the right places and shapes and look the same as in Shopware layout.

Actual behavior
Pictures are displayed in wrong places and shapes on the website.

Screenshots
'Three columns, rounded' block in Shopware 'Shopping Experiences' layout:
3columRoundedShopware

'Three columns, rounded' block on the website looks like this:
3columnRoundedWeb

Devices (please complete the following information):
All devices

@akrajna
Copy link
Collaborator Author

akrajna commented Mar 18, 2020

'Three columns, rounded' block works correctly.
For the other blocs ( 'Two columns, boxed', 'Three columns, boxed', 'Three columns, full-sized',' Four columns, boxed', 'Three columns, boxed & background', 'Image grid') new issues will be created.

@Michal-Dziedzinski
Copy link
Collaborator

However, we return to the idea of a joint issue to avoid conflicts with pull requests. The idea of creating components has changed after plugins workshop (separete components for every block)

@rmakara
Copy link
Collaborator

rmakara commented Apr 17, 2020

Blocked by #234

@rmakara
Copy link
Collaborator

rmakara commented Apr 17, 2020

PR for this issue must be adjusted up to the new requirements after merging #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMS components
Projects
None yet
4 participants