-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Calls to Action inside text elements should be parsed #649
Comments
There are a couple of ways to achieve this. To parse components inside a string you either have to:
First option is way more convenient, faster to implement and readable (especially for those who don't have much familiarity with render functions), although bundle size would be bigger. Performance-wise, I don't think that there is much difference between the two options, since the HTML that gets parsed is not so much complex (IMHO). I'd like to hear something from you guys so I can make the pull request happen. |
@Rigo-m great input |
Description
Calls to Action (which are called
link
in the Shopware editor) insidetext
element
s should be parsed to become a storefront-ui CTA atom.Acceptance criteria
text
element
should be parsed into a storefront-ui cta (or equivalent)text
element
should come from the same component and be equivalentThe text was updated successfully, but these errors were encountered: