-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No photos of related product color variants in the cart (offline mode) #2897
Comments
There was kind of change how the gallery works in 1.10rc-1 - previously (demo) - the 310x300 size picture was always prefetched and then upgraded with the higher quality image (the effect of progressive loading was just caused by this behavior). Now it's not. Microcart is using 310x300 Progressive loading on demo: This issue causes also the lack of placeholders for gallery images - the issue I've raised Today morning to @patzick @patzick how about this one? Has it just been fixed? As we see in here we should prefetch the 310x300 for the Microcart or somehow use the other thumbnail in microcart - maybe even just use the standard thumbnail (it will be missleading - because it will have the wrong color) |
By the way - when the picture hasn't been prefetched before the problem also existsin on demo env: https://www.dropbox.com/s/z4hob1biqw59zgc/Screenshot%202019-05-14%2014.24.55.png?dl=0 That means we should make sure we use prefetched thumbnail in the Microcart. The only guaranteed thumbnail we have in the offline mode is the main-one and I belive it's a tradeoff we can accept. So - we can modify the Microcart./Product.vue to display the 310x300 thumbnail of the |
We should somehow mark which image (path + size) has been |
Related to #2863 |
Closed by #3013 |
Current behavior
After adding many color variants of the product to the cart, and then switching to the offline mode - photos of related product color variants are not visible in the cart.
Expected behavior
After adding many color variants of the product to the cart, and then switching to the offline mode - photos of related product color variants are visible in the cart.
Steps to reproduce the issue
Can you handle fixing this bug by yourself?
Which Release Cycle state this refers to? Info for developer.
Pick one option.
develop
branch and create Pull Request2. Feature / Improvement
back todevelop
.release
branch and create Pull Request3. Stabilisation fix
back torelease
.hotfix
ormaster
branch and create Pull Request4. Hotfix
back tohotfix
.Environment details
Additional information
This issue doesn't appear on demo.
The text was updated successfully, but these errors were encountered: