Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ./packages as volume to docker-compose.yml #3251

Closed
2 of 5 tasks
cewald opened this issue Jul 18, 2019 · 1 comment
Closed
2 of 5 tasks

Add ./packages as volume to docker-compose.yml #3251

cewald opened this issue Jul 18, 2019 · 1 comment
Labels
bug Bug reports
Milestone

Comments

@cewald
Copy link
Contributor

cewald commented Jul 18, 2019

Current behavior

If you start VSF via docker-compose the following error occurs:

yarn install v1.13.0
[1/5] Validating package.json...
[2/5] Resolving packages...
error Couldn't find any versions for "@vue-storefront/module" that matches "^0.0.9"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

It's neccessary to add the ./packages folder to the docker-compose.yml like:

services:
  app:
    # image: divante/vue-storefront:latest
    build:
      context: .
      dockerfile: docker/vue-storefront/Dockerfile
    env_file: docker/vue-storefront/default.env
    environment:
      VS_ENV: dev
    network_mode: host
    volumes:
      - './babel.config.js:/var/www/babel.config.js'
      - './config:/var/www/config'
      - './core:/var/www/core'
      - './ecosystem.json:/var/www/ecosystem.json'
      - './.eslintignore:/var/www/.eslintignore'
      - './.eslintrc.js:/var/www/.eslintrc.js'
      - './lerna.json:/var/www/lerna.json'
      - './tsconfig.json:/var/www/tsconfig.json'
      - './tsconfig-build.json:/var/www/tsconfig-build.json'
      - './shims.d.ts:/var/www/shims.d.ts'
      - './package.json:/var/www/package.json'
      - './src:/var/www/src'
      - './var:/var/www/var'
      - './packages:/var/www/packages'
    tmpfs:
      - /var/www/dist
    ports:
      - '3000:3000'

Expected behavior

It should build and run the app on start.

Steps to reproduce the issue

Just run docker-compose up

Repository

develop

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: none
  • OS: all
  • Node: default
  • Code Version: develop
@patzick
Copy link
Collaborator

patzick commented Jul 18, 2019

Thanks @cewald ! :)

@patzick patzick closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports
Projects
None yet
Development

No branches or pull requests

2 participants