Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for core/modules/mailer #3463

Closed
3 tasks
pkarw opened this issue Sep 3, 2019 · 2 comments
Closed
3 tasks

Add unit tests for core/modules/mailer #3463

pkarw opened this issue Sep 3, 2019 · 2 comments
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can S: Small effort Small change to existing code, will take 1 or a couple of hours vs-hackathon Tasks for the Hackathon

Comments

@pkarw
Copy link
Collaborator

pkarw commented Sep 3, 2019

What is the motivation for adding/enhancing this feature?

Add unit tests for the module. Reference/example:

What are the acceptance criteria

  • all the actions should be tested
  • all the helpers should be tested
  • all the mutations should be tested
@pkarw pkarw added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can 1: Easy S: Small effort Small change to existing code, will take 1 or a couple of hours labels Sep 3, 2019
@krskibin
Copy link
Collaborator

krskibin commented Oct 7, 2019

I'll take this one. Can you assign me?

@pkarw
Copy link
Collaborator Author

pkarw commented Oct 7, 2019

@krskibin we can only assign issues to the core team members, but feel free to take this one; it's yours ;)

@lukeromanowicz lukeromanowicz added the vs-hackathon Tasks for the Hackathon label Oct 10, 2019
This was referenced Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can S: Small effort Small change to existing code, will take 1 or a couple of hours vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

4 participants