Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistore -> nested routes names duplicated #3489

Closed
3 tasks
kamileon-div opened this issue Sep 5, 2019 · 6 comments
Closed
3 tasks

Multistore -> nested routes names duplicated #3489

kamileon-div opened this issue Sep 5, 2019 · 6 comments
Labels
bug Bug reports P3: Normal Priority mark - normal priority
Milestone

Comments

@kamileon-div
Copy link

kamileon-div commented Sep 5, 2019

Current behavior

When create a children route, it duplicates without language prefix.

Expected behavior

Nested routes names should be prefixed by each language.

Steps to reproduce the issue

Use multistore and create children route.

Can you handle fixing this bug by yourself?

  • [x ] YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • [x ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome
  • OS: Windows
  • Node: 10
  • Code Version: 1.10.1
@kamileon-div kamileon-div added the bug Bug reports label Sep 5, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 5, 2019

Hi! Thanks, can you paste example routing config to show the case please?

@pkarw
Copy link
Collaborator

pkarw commented Sep 5, 2019

setupMultistoreRoutes from multistore.ts is adding the localized routes

@pkarw pkarw added the P3: Normal Priority mark - normal priority label Sep 5, 2019
@pkarw pkarw assigned patzick and unassigned patzick Sep 5, 2019
@kamileon-div
Copy link
Author

Of course. Code below:

{ name: 'account', path: '/my-account', component: MyAccount, meta: { requiresAuth: true }, children: [ { name: 'account-settings', path: 'settings', component: AccountSettings, props: { page: 'lorem', title: 'Account settings' }, meta: { requiresAuth: true } } ] },

@pkarw
Copy link
Collaborator

pkarw commented Sep 5, 2019

yeah, we forgot about this :) can you please fix it? thanks!

@pkarw pkarw added this to the 1.11.0-rc.1 milestone Sep 5, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 10, 2019

I just wanted to check up the status? The 1.11rc1 is planned for 19th of September

@lysy-vlc
Copy link
Contributor

It seems that the problem is a little bit more complicated. I have to study it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports P3: Normal Priority mark - normal priority
Projects
None yet
Development

No branches or pull requests

4 participants