Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error applying coupon. #3578

Closed
1 of 5 tasks
alinadivante opened this issue Sep 18, 2019 · 3 comments
Closed
1 of 5 tasks

Error applying coupon. #3578

alinadivante opened this issue Sep 18, 2019 · 3 comments
Assignees
Labels
1: Easy bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@alinadivante
Copy link
Collaborator

Current behavior

When you try to apply valid discount coupon, nothing happens and there is error in dev console.
image

Expected behavior

The discount coupon should be applied.

Steps to reproduce the issue

  1. Run the latest develop version
  2. Add any product to the cart
  3. Apply valid discount code, e.g. mmtest

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label Sep 18, 2019
@alinadivante alinadivante added this to the 1.11.0-rc.1 milestone Sep 18, 2019
@pkarw pkarw added 1: Easy P1: Urgent Priority mark - high priority labels Sep 18, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 18, 2019

Probably related to cart refactor(?)

@andrzejewsky
Copy link
Contributor

It's not related to the refactor for sure. It seems like wrong reference to the applyCoupon I'm guessing there is some missing mixin... but I'll check, I'm pretty sure it'll be a quick fix

@andrzejewsky
Copy link
Contributor

ahh even I can see it now... there is no mapped action, It supposed to be this.$store.dispatch('cart/applyCoupon', this.couponCode) call or applyCoupon mapped. I'll fix it.

@pkarw pkarw closed this as completed Sep 20, 2019
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Sep 20, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

3 participants