Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key additionalIncludeFields #3763

Closed
2 of 6 tasks
benjick opened this issue Oct 30, 2019 · 1 comment
Closed
2 of 6 tasks

Add key additionalIncludeFields #3763

benjick opened this issue Oct 30, 2019 · 1 comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P4: Nice to have Priority mark - it's nice to have

Comments

@benjick
Copy link
Contributor

benjick commented Oct 30, 2019

What is the motivation for adding / enhancing this feature?

It's not very nice to have to keep all the default fields in my config just to add a single one. I'm suggesting a new key called additionalIncludeFields which will be merged with includeFields

What are the acceptance criteria

  • Being able to add new fields to additionalIncludeFields which are merged with includeFields during build time

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@benjick benjick added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Oct 30, 2019
@benjick benjick changed the title Add field additionalIncludeFields Add key additionalIncludeFields Oct 30, 2019
@pkarw pkarw added the P4: Nice to have Priority mark - it's nice to have label Oct 30, 2019
@pkarw
Copy link
Collaborator

pkarw commented Nov 14, 2019

I think this is not necessary needed feature - complicating our - already complicated configs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P4: Nice to have Priority mark - it's nice to have
Projects
None yet
Development

No branches or pull requests

2 participants