Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing defaultLocale to jp-JP in local.json is not working #3824

Closed
3 tasks done
hawaiiden opened this issue Nov 20, 2019 · 1 comment
Closed
3 tasks done

Changing defaultLocale to jp-JP in local.json is not working #3824

hawaiiden opened this issue Nov 20, 2019 · 1 comment
Labels
question If you are not sure how sth works or want discuss someting

Comments

@hawaiiden
Copy link

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Information

I tried to change language and currency of my VS, so I edited i18n in local.json
like this,

"i18n": {
      "defaultCountry": "JP",
      "defaultLanguage": "JP",
      "availableLocale": ["en-US","de-DE","fr-FR","es-ES","nl-NL", "jp-JP", "ru-RU", "it-IT", "pt-BR", "pl-PL", "cs-CZ"],
      "defaultLocale": "jp-JP",
      "currencyCode": "JPY",
      "currencySign": "円",
      "currencySignPlacement": "append",
      "dateFormat": "l LT",
      "fullCountryName": "Japan",
      "fullLanguageName": "Japanese",
      "bundleAllStoreviewLanguages": true
    }

Every locale is working except jp-JP, which is above way.
The error message is,

Error during render : /error
{ Error: Cannot find module './jp'
    at server-bundle.js:26736:12
    at process._tickCallback (internal/process/next_tick.js:68:7) code: 'MODULE_NOT_FOUND' }
(node:40996) UnhandledPromiseRejectionWarning: Error: Cannot find module './jp'
  1. If there is better way to change language and currency of VS, please let me know.
  2. Why only Japan option is not working? Is this normal or I did something wrong? or should I install anything like Japanese language module?
@hawaiiden hawaiiden added the question If you are not sure how sth works or want discuss someting label Nov 20, 2019
@pkarw
Copy link
Collaborator

pkarw commented Nov 21, 2019

Fixed by #3831

@pkarw pkarw closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question If you are not sure how sth works or want discuss someting
Projects
None yet
Development

No branches or pull requests

2 participants