Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTimePicker): AM/PM farsi translation and margins in RTL mode #10399

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Jan 31, 2020

Motivation and Context

Fixes few issues from #6757:

  • margins of am/pm in title
  • Farsi translations of am/pm
  • typing of VTimePickerTItle.format prop

image

How Has This Been Tested?

playground

Markup:

<template>
  <v-container fluid style="width: 314px">
    <v-btn block @click="$vuetify.rtl = !$vuetify.rtl">RTL: {{ $vuetify.rtl }}</v-btn>
    <v-time-picker />
    <v-time-picker format="24hr" />
    <v-time-picker ampm-in-title />
    <v-time-picker format="24hr" ampm-in-title />
  </v-container>
</template>

<script>
  import Vue from 'vue';
  import { fa } from '../src/locale'
  export default Vue.extend({
    created () {
      this.$vuetify.lang.locales.en = fa
    }
  })
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.2.x milestone Feb 1, 2020
@jacekkarczmarczyk jacekkarczmarczyk merged commit a6761a9 into master Feb 1, 2020
@jacekkarczmarczyk jacekkarczmarczyk deleted the fix/ampm-rtl branch February 1, 2020 17:44
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VTimePicker VTimePicker rtl T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants