Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTimePicker): missing end circle in clock hand #10415

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

jacekkarczmarczyk
Copy link
Member

How Has This Been Tested?

playground

Markup:

<template>
  <v-time-picker
    ref="p"
    value="1:07"
  />
</template>

<script>
  export default {
    mounted () {
      this.$refs.p.selecting = 2
    }
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected C: VTimePicker VTimePicker labels Feb 1, 2020
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.2.x milestone Feb 1, 2020
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Feb 1, 2020
@johnleider johnleider merged commit 755c5b8 into master Feb 1, 2020
@johnleider johnleider deleted the fix/time-picker-hand branch February 1, 2020 18:18
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VTimePicker VTimePicker T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants