Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSelect): expose clickable icons to screen readers #10489

Merged
merged 3 commits into from
Feb 6, 2020

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Feb 6, 2020

Description

Related: #10461, #10439

Markup:

<template>
  <v-container>
    <v-select clearable prepend-inner-icon="mdi-vuetify" menu-props="offsetY" @click:prepend-inner="" :items="['a', 'b', 'c']" v-model="selected"></v-select>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      selected: null
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VSelect VSelect labels Feb 6, 2020
@KaelWD KaelWD added this to the v2.2.x milestone Feb 6, 2020
@KaelWD KaelWD changed the title fix(VSelect): allow clickable append/prepend icons to be focused fix(VSelect): expose clickable icons to screen readers Feb 6, 2020
@johnleider johnleider merged commit cee1404 into master Feb 6, 2020
@johnleider johnleider deleted the fix/select-icon-a11y branch February 6, 2020 15:07
rachael-smith pushed a commit to rachael-smith/vuetify that referenced this pull request Feb 7, 2020
* fix(VSelect): allow clickable append/prepend icons to be focused

* refactor(VTextField): always render a named icon when clearable

* refactor(VInput): use default argument instead of or operator
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants