Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Dialog - broke in 2.2 #10536

Closed
GautierDele opened this issue Feb 10, 2020 · 6 comments
Closed

[Bug Report] Dialog - broke in 2.2 #10536

GautierDele opened this issue Feb 10, 2020 · 6 comments
Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected

Comments

@GautierDele
Copy link

Environment

Vuetify Version: 2.2.11
Last working version: 2.1.0
Vue Version: 2.6.11
Browsers: Chrome 80.0.3987.87
OS: Windows 10

Steps to reproduce

Click on the dialog button and the second dialog isn't appearing

Expected Behavior

There should be a second button in order to open a second dialog

Actual Behavior

No button given

Reproduction Link

https://codepen.io/gautierdele/pen/GRJJEJL

Other comments

It also seems in my application that event propagation is no longer stopped... When I click in the dialog it trigger the parent

@ghost ghost added the S: triage label Feb 10, 2020
@GautierDele
Copy link
Author

I just tested in 2.1.18 and it seems to be working. So I guess it's a 2.2 modification but I can't find in the releases the point talking about it ...

@MajesticPotatoe
Copy link
Member

works in 2.2.8
likely related to #10522

@jacekkarczmarczyk
Copy link
Member

Fixed in cc17fe1

@GautierDele
Copy link
Author

GautierDele commented Feb 13, 2020

Effectively the tuesday realease did fix one of the problem but i'm still getting the problem that the events seems to propagate through dialog.
On my app if I click on a dialog it triggers the parent click event even if it's not visible since the dialog is fullscreen.

As you can see in this codepen: https://codepen.io/gautierdele/pen/GRJJEJL
When we click anywhere in the fullscreen dialog it actually triggers the event as it used not to (downgrade the package to 2.1.18 in the settings and you will see it wont)

Gautier

@KaelWD
Copy link
Member

KaelWD commented Feb 13, 2020

That's intentional: #10167

@GautierDele
Copy link
Author

Ok i did not know, mooving the event to the content element fixed the problem.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

4 participants