Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VFileInput): prevent label and placeholder overlap #12891

Conversation

juddfranklin1
Copy link
Contributor

fixes #12864

Description

Motivation and Context

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <v-container>
      <v-file-input
        accept="image/*"
        label="File input"
        placeholder="placeholder"
      ></v-file-input>
      <v-file-input
        accept="image/*"
        label="File input 2"
      ></v-file-input>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
    //
    }),
  }
</script>

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • [x ] The PR title is no longer than 64 characters.
  • [x ] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • [x ] My code follows the code style of this project.
  • [x ] I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@MajesticPotatoe MajesticPotatoe added C: VFileInput T: bug Functionality that does not work as intended/expected labels Jan 5, 2021
@MajesticPotatoe MajesticPotatoe added this to the v2.4.x milestone Jan 5, 2021
@johnleider johnleider self-requested a review January 5, 2021 22:57
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of adding a property to fix a bug. This should follow the same logic as v-text-field which was altered in ff500ba for a11y concerns.

@juddfranklin1
Copy link
Contributor Author

juddfranklin1 commented Jan 6, 2021

I don't like the idea of adding a property to fix a bug. This should follow the same logic as v-text-field which was altered in ff500ba for a11y concerns.

This is helpful, thanks. I was a little uneasy about the approach, but didn't know about the comparable solution in v-text-field

@juddfranklin1 juddfranklin1 force-pushed the bug/file-input-label-placeholder-placement branch 2 times, most recently from 4a829fc to f6ea91b Compare January 7, 2021 18:13
@KaelWD KaelWD force-pushed the master branch 12 times, most recently from ddbea7b to c7a93f7 Compare February 19, 2021 14:19
@KaelWD KaelWD merged commit ff2fbb1 into vuetifyjs:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VFileInput T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] File input label and placeholder
4 participants