Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] VCalendarCategory : Bad columns construction #12970

Closed
alann-sapone opened this issue Jan 15, 2021 · 2 comments
Closed

[Bug Report] VCalendarCategory : Bad columns construction #12970

alann-sapone opened this issue Jan 15, 2021 · 2 comments
Labels
duplicate The issue has already been reported

Comments

@alann-sapone
Copy link

Environment

Vuetify Version: 2.4.2
Vue Version: 2.6.11
Browsers: Chrome 87.0.4280.141
OS: Windows 10

Steps to reproduce

  • Create a VCalendar with category mode.
  • Set more than 2 days to display
  • Set a fixed number of categories, like 2

Expected Behavior

  • We should have 1 day body for each day.
  • We should also have one column for each category in that day
  • And then each events for that category

Bonus: We should be able to filter days defined in weekdays props

Actual Behavior

We can see that we have 2 columns instead of five. And events are blindly added to that

Reproduction Link

https://codepen.io/devoluti0n/pen/wvzRWgq

Other comments

  • In VCalendarCategory.js line 69, days should be based on days length, not categories length.
  • From that, we should have a loop in genDayBody for each parsed category, and not only one, so that events are in their specific categories.
  • And from that, events should be specific to their categories (I didn't search for the duplication reason yet)
@ghost ghost added the S: triage label Jan 15, 2021
@MajesticPotatoe MajesticPotatoe added C: VCalendar T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke and removed S: triage labels Jan 15, 2021
@MajesticPotatoe MajesticPotatoe added this to the v2.4.x milestone Jan 15, 2021
@MajesticPotatoe
Copy link
Member

related/duplicate of #12967

@KaelWD
Copy link
Member

KaelWD commented Feb 23, 2021

Duplicate of #12967

@KaelWD KaelWD marked this as a duplicate of #12967 Feb 23, 2021
@KaelWD KaelWD closed this as completed Feb 23, 2021
@KaelWD KaelWD added duplicate The issue has already been reported and removed C: VCalendar T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke labels Feb 23, 2021
@KaelWD KaelWD removed this from the v2.4.x milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate The issue has already been reported
Projects
None yet
Development

No branches or pull requests

3 participants