-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VTextField): legend position not aligned with reverse prop #13051
Conversation
Sorry I missed that this was specific to firefox. My other comment still stands however. |
@@ -371,6 +371,9 @@ export default baseMixins.extend<options>().extend({ | |||
style: { | |||
width: !this.isSingle ? convertToUnit(width) : undefined, | |||
}, | |||
attrs: { | |||
align: this.reverse ? 'right' : 'left', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would've asked you to redo with CSS anyway, this attribute is deprecated and doesn't account for RTL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1488228
Looks like using margin instead of text-align works in firefox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KaelWD , Will verify the same and update the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KaelWD As mentioned in the Mozilla patch here https://bugzilla.mozilla.org/attachment.cgi?id=9006391
These changes seems to fix it.
@@ -433,10 +433,12 @@ | |||
|
|||
&.v-text-field--reverse legend | |||
+ltr() | |||
text-align: right | |||
margin-inline-start: auto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IE doesn't support this property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jacekkarczmarczyk. Didn't knew about that, Update and tested on Chrome, Edge, IE and Firefox
fix(VTextField): legend position not aligned with reverse prop
Description
Legend position was not aligned with the reverse prop that reverses the label position. So when the value of the reverse prop is true the legend should move right
fixes #10798
Motivation and Context
Done to Fix #10798
How Has This Been Tested?
Visually via playground on Chrome, Edge, IE and Morzilla
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).