-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VRating): make icons tab-accessible #13098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting tab index to 0 so we can tab to the button
Please let me know if there is something more that needs to be done! |
KaelWD
reviewed
Feb 12, 2021
Thanks. Not sure how that was missed for so long, even in #12345 |
Happy to help! I removed the tabindex completely. Let me know if anything else is needed. Thanks! |
It works for me in the vercel preview! |
hey hey @KaelWD, anything else needed from me (other then patience)? I'd love to get this fix into my website. |
KaelWD
approved these changes
Feb 17, 2021
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set tabindex to 0 so we can tab to the button and press enter.
resolves #10820
Motivation and Context
This makes the buttons generated by v-rating accessible.
fixes #10820
How Has This Been Tested?
Tested visually. Ran with NVDA, can tab to the buttons and aria-labels are read.
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).