Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VRating): make icons tab-accessible #13098

Merged
merged 2 commits into from
Feb 17, 2021
Merged

fix(VRating): make icons tab-accessible #13098

merged 2 commits into from
Feb 17, 2021

Conversation

rkrasnan
Copy link
Contributor

Description

Set tabindex to 0 so we can tab to the button and press enter.
resolves #10820

Motivation and Context

This makes the buttons generated by v-rating accessible.
fixes #10820

How Has This Been Tested?

Tested visually. Ran with NVDA, can tab to the buttons and aria-labels are read.

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

setting tab index to 0 so we can tab to the button
@rkrasnan
Copy link
Contributor Author

Please let me know if there is something more that needs to be done!

@rkrasnan rkrasnan changed the title Set tabindex to 0 in VRating.ts to make the button Accessible fix(VRating): set tabindex to 0 to make the button accessible Feb 12, 2021
@KaelWD
Copy link
Member

KaelWD commented Feb 12, 2021

Thanks. Not sure how that was missed for so long, even in #12345

@rkrasnan
Copy link
Contributor Author

Happy to help! I removed the tabindex completely. Let me know if anything else is needed. Thanks!

@rkrasnan
Copy link
Contributor Author

rkrasnan commented Feb 12, 2021

It works for me in the vercel preview!

@rkrasnan
Copy link
Contributor Author

rkrasnan commented Feb 16, 2021

hey hey @KaelWD, anything else needed from me (other then patience)? I'd love to get this fix into my website.

@johnleider johnleider added C: VRating T: bug Functionality that does not work as intended/expected labels Feb 16, 2021
@johnleider johnleider added this to the v2.4.x milestone Feb 16, 2021
@johnleider johnleider requested a review from KaelWD February 16, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VRating T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-rating does not allow accessible keyboard navigation
3 participants