Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VColorPicker): Allow swatches to be disabled #13208

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Mar 4, 2021

fixes #13160

Description

fixes #13160

Motivation and Context

close #13160

How Has This Been Tested?

visually

Markup:

// Paste your FULL Playground.vue here
<template>
  <v-container>
    <v-row>
      <v-col>
        <h3>Enabled</h3>
        <v-color-picker show-swatches></v-color-picker>
      </v-col>
      <v-col>
        <h3>Disabled</h3>
        <v-color-picker show-swatches disabled></v-color-picker>
      </v-col>
      <v-col>
        <h3>The problem</h3>
        <p>
          While canvas, inputs and sliders are all "disabled" and cannot be
          interacted with, the swatches can still be used.
        </p>
      </v-col>
    </v-row>
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD KaelWD changed the title fix(VColorPickerSwatches): Add disabled prop and disabled effect fix(VColorPicker): Allow swatches to be disabled Mar 6, 2021
@KaelWD KaelWD added the T: bug Functionality that does not work as intended/expected label Mar 6, 2021
@KaelWD KaelWD added this to the v2.4.x milestone Mar 6, 2021
@KaelWD KaelWD merged commit ed76169 into vuetifyjs:master Mar 6, 2021
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VColorPicker T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-color-picker swatches not respecting "disabled"
2 participants