Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBtn): prevent keyboard tab while loading #18639

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

Mohib834
Copy link
Contributor

@Mohib834 Mohib834 commented Nov 9, 2023

Description

When the loading prop is true, Vbtn still lets the user select the button through the tab and register the enter event.

resolves #18524

Markup:

<template>
  <v-card
    class="mx-auto"
    max-width="450"
    title="Strengthen your passwords"
    text="Update your weak or re-used passwords with Password Checkup. It's free and only takes a few minutes. Click the Take Checkup button to get started."
  >
    <template #actions>
      <v-btn height="48"> No Thanks </v-btn>

      <v-btn
        :loading="loading"
        class="flex-grow-1"
        height="48"
        variant="tonal"
        @click="load"
      >
        Take Checkup
      </v-btn>

    </template>
  </v-card>
</template>

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VBtn labels Nov 10, 2023
@johnleider
Copy link
Member

Are there any accessibility with aria attributes that we need to take into consideration?

@johnleider johnleider requested a review from KaelWD December 12, 2023 14:03
@johnleider johnleider force-pushed the master branch 8 times, most recently from 7cd11a6 to d0765f1 Compare December 17, 2023 01:32
@johnleider johnleider force-pushed the master branch 2 times, most recently from f931c2e to 748056c Compare December 28, 2023 22:41
@johnleider
Copy link
Member

Paging @Mohib834

@johnleider johnleider added the S: stale This issue is untriaged and hasn't seen any activity in at least six months. label Jan 17, 2024
@KaelWD KaelWD force-pushed the master branch 3 times, most recently from cd170f8 to 98e57dc Compare February 14, 2024 06:14
@johnleider johnleider removed the S: stale This issue is untriaged and hasn't seen any activity in at least six months. label Mar 28, 2024
@johnleider johnleider added this to the v3.5.x milestone Mar 28, 2024
@johnleider johnleider merged commit bf65296 into vuetifyjs:master Mar 28, 2024
8 checks passed
@johnleider johnleider changed the title fix(VBtn): prevent keyboard tab from triggering the loading button fix(VBtn): prevent keyboard tab while loading Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VBtn T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.3.22] button can't be clicked while loading but accepts keyboard
3 participants