Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSelect): closing chip removes selection #19242

Merged
merged 2 commits into from
Feb 21, 2024
Merged

fix(VSelect): closing chip removes selection #19242

merged 2 commits into from
Feb 21, 2024

Conversation

yuwu9145
Copy link
Member

fixes #19235

Ensure consistency in the select logic between VAutocomplete and VSelect

Description

Markup:

<template>
  <v-app>
    <v-container>
      <v-label text="V-Select without multiple prop"></v-label>
      <v-autocomplete
        v-model="currentValue"
        clearable
        chips
        closable-chips
        label="Select"
        :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
      />
      <v-select
        v-model="currentValue"
        clearable
        chips
        closable-chips
        label="Select"
        :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
      ></v-select>
      Current Value: {{currentValue}}
      <hr />
      <v-label class="mt-10" text="V-Select with multiple prop"></v-label>
      <v-select
        v-model="currentValue"
        clearable
        chips
        closable-chips
        label="Select"
        :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
        multiple
      ></v-select>
    </v-container>
  </v-app>
</template>
<script setup>
  import { ref } from 'vue'

  const currentValue = ref('California')
</script>

@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VSelect C: VAutocomplete labels Feb 21, 2024
@johnleider johnleider added this to the v3.5.x milestone Feb 21, 2024
@johnleider johnleider merged commit b5c7660 into master Feb 21, 2024
12 of 13 checks passed
@johnleider johnleider deleted the fix-19235 branch February 21, 2024 15:33
VIXI0 pushed a commit to VIXI0/vuetify that referenced this pull request Mar 13, 2024
fixes vuetifyjs#19235

Co-authored-by: John Leider <john@vuetifyjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAutocomplete C: VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.5.4] V-Select closable chips don't update v-model value unless multiple prop is set
2 participants