Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSwitch): label when using direction vertical #19504

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

De-Hann
Copy link
Contributor

@De-Hann De-Hann commented Mar 28, 2024

Feature to fix #18952

Added direction prop on VSelect and added styling to VSwitch

<template>
  <v-app>
    <v-container>
      <v-switch
        v-model="model"
        direction="vertical"
        label="Vertical"
      ></v-switch>
      <v-switch
        v-model="model"
        direction="horizontal"
        label="Horizontal"
      ></v-switch>
      <v-switch v-model="model" label="Default"></v-switch>
    </v-container>
  </v-app>
</template>

<script>
export default {
  name: "Playground",
  data: () => ({
    model: false,
  }),
};
</script>

@@ -356,6 +361,7 @@ export const VSelect = genericComponent<new <
[`v-select--${props.multiple ? 'multiple' : 'single'}`]: true,
'v-select--selected': model.value.length,
'v-select--selection-slot': !!slots.selection,
[`v-input--${props.direction.valueOf}`]: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is valueOf needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not, removed it

packages/vuetify/src/components/VSelect/VSelect.tsx Outdated Show resolved Hide resolved
@johnleider johnleider added S: stale This issue is untriaged and hasn't seen any activity in at least six months. and removed S: stale This issue is untriaged and hasn't seen any activity in at least six months. labels Mar 28, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VSwitch labels Mar 29, 2024
@johnleider
Copy link
Member

Could you reach out to me on Discord? https://community.vuetifyjs.com

@johnleider johnleider added this to the v3.5.x milestone Mar 29, 2024
@johnleider johnleider changed the title fix(VSelect/VSwitch): Added direction prop to VSwitch and VSelect fix(VSwitch): label when using direction vertical Mar 29, 2024
@johnleider johnleider merged commit 6748fd7 into vuetifyjs:master Mar 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VSwitch T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.4.9] v-switch vertical direction not working
2 participants