-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VNavigationDrawer): allow temporary drawers to be persistent #19552
Merged
johnleider
merged 6 commits into
vuetifyjs:dev
from
vstyler96:persistent-drawer-feature
Apr 22, 2024
Merged
feat(VNavigationDrawer): allow temporary drawers to be persistent #19552
johnleider
merged 6 commits into
vuetifyjs:dev
from
vstyler96:persistent-drawer-feature
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajesticPotatoe
added
T: feature
A new feature
C: VNavigationDrawer
VNavigationDrawer
labels
Apr 9, 2024
MajesticPotatoe
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- rebase to
dev
johnleider
force-pushed
the
persistent-drawer-feature
branch
from
April 9, 2024 14:25
6a66aa9
to
b8fb031
Compare
johnleider
force-pushed
the
persistent-drawer-feature
branch
from
April 9, 2024 14:27
b8fb031
to
3b042c8
Compare
…ify into persistent-drawer-feature
This has unrelated changes. |
@johnleider This should be ready again 😄 |
vstyler96
changed the title
feat(VNavigationDrawer): Allo temporary drawers to be persistent
feat(VNavigationDrawer): Allow temporary drawers to be persistent
Apr 22, 2024
johnleider
changed the title
feat(VNavigationDrawer): Allow temporary drawers to be persistent
feat(VNavigationDrawer): allow temporary drawers to be persistent
Apr 22, 2024
johnleider
approved these changes
Apr 22, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows use
persistent
attribute intemporary
VNavigationDrawer, so we can prevent closing the drawer on outside click, and instead close the drawer programatically when its temporary.Markup: