-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VHover): false isHovering by default #19623
Conversation
From @KaelWD's comment, should this be null as default? |
3b0f775
to
90f1ba3
Compare
Yeah I guess it should work better if someone wants to check for an element being untouched. I've introduced the fix, please check. |
90f1ba3
to
f4fe3d1
Compare
@@ -7,7 +7,7 @@ import { genericComponent, propsFactory } from '@/util' | |||
|
|||
type VHoverSlots = { | |||
default: { | |||
isHovering: boolean | undefined | |||
isHovering: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be boolean | null
?
@KaelWD Yeah you're right. I had to mess with other components to make typescript happy. Please review. |
modelValue: { | ||
type: Boolean as PropType<boolean | null>, | ||
default: null, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops things got a bit out of hand there. This cast should be removed.
Description
fixes #19601
Markup: