fix(VSlider): add aria-label to v-slider-thumb #19887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes add a `name` prop to the `VSliderThumb` component in order to pass it down to the underlying element. This allows for better accessibility by providing an `aria-label` attribute with the value of the `name` prop.
tilenpirih
changed the title
tilenpirih
changed the title
johnleider
requested changes
May 24, 2024
Co-authored-by: John Leider <9064066+johnleider@users.noreply.github.com>
Co-authored-by: John Leider <9064066+johnleider@users.noreply.github.com>
johnleider
added
T: bug
johnleider
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessability problem with v-slider component.
The code pass
nameprop to slider thumb component and uses name as an aria-label value. If name prop isn't passed it just usesSlideras a default aria-label value.