Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.6.8] Type errors revealed by stricter app.provide() type in Vue core #19979

Closed
yyx990803 opened this issue Jun 10, 2024 · 0 comments
Closed

[Bug Report][3.6.8] Type errors revealed by stricter app.provide() type in Vue core #19979

yyx990803 opened this issue Jun 10, 2024 · 0 comments
Assignees
@KaelWD
Labels
framework Issues and Feature Requests that have needs framework-wide. T: bug Functionality that does not work as intended/expected
Milestone
v3.6.x

Comments

@yyx990803
Copy link
Contributor

yyx990803 commented Jun 10, 2024 •
edited
Loading

Environment

Vuetify Version: master
Vue Version: main (to be released in 3.4.28)

Steps to reproduce

Vue core PR vuejs/core#10603 made app.provide type-safe and enforce type match on InjectionKey and provided value. This reveals two type mismatches in Vuetify src which seem to be legit errors.

Expected Behavior

Types match

Actual Behavior

Types are not matching

Reproduction Link

https://github.com/vuejs/ecosystem-ci/actions/runs/9445520695/job/26013310766
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected framework Issues and Feature Requests that have needs framework-wide. labels Jun 10, 2024
@KaelWD KaelWD self-assigned this Jun 10, 2024
@KaelWD KaelWD added this to the v3.6.x milestone Jun 10, 2024
@KaelWD KaelWD closed this as completed in d8e8a0c Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
framework Issues and Feature Requests that have needs framework-wide. T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.6.x
Development

No branches or pull requests
2 participants
@yyx990803 @KaelWD