-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VDataTable): use item.raw and columns in sorting transform #20077
Merged
johnleider
merged 4 commits into
vuetifyjs:master
from
tongxuanbao:fix/20045-VDataTable-not-sorted-absent-header
Jul 16, 2024
Merged
fix(VDataTable): use item.raw and columns in sorting transform #20077
johnleider
merged 4 commits into
vuetifyjs:master
from
tongxuanbao:fix/20045-VDataTable-not-sorted-absent-header
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongxuanbao
changed the title
fix: using raw instead
fix(VDataTable): used raw for table sorting instead of column
Jun 29, 2024
tongxuanbao
changed the title
fix(VDataTable): used raw for table sorting instead of column
fix(VDataTable): used a combination of raw and columns in sorting item transformation
Jul 3, 2024
This looks good. Was hoping this fixed an issue with group by sort getting overriden by sort-by prop, but it does not. |
Do you have a reproduce of the issue ? It might be related |
@tongxuanbao Another PR appears to be fixing the issue I am describing. You can take a look at it if you like. |
johnleider
added
T: bug
Functionality that does not work as intended/expected
C: VDataTable
VDatatable
labels
Jul 10, 2024
johnleider
approved these changes
Jul 10, 2024
johnleider
changed the title
fix(VDataTable): used a combination of raw and columns in sorting item transformation
fix(VDataTable): use item.raw and columns in sorting transform
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #20045
Markup: