Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.6.12] v-textarea and v-text-field icon/button alignment issue #20159

Closed
mschoeffmann opened this issue Jul 13, 2024 · 5 comments
Closed

Comments

@mschoeffmann
Copy link

Environment

Vuetify Version: 3.6.12
Last working version: 3.6.11
Vue Version: 3.4.31
Browsers: Safari 17.5
OS: Mac OS 10.15.7

Steps to reproduce

Switch from v3.6.11 to v3.6.12 in the Playground to see the alignement issue.

The provided workaround in #20154 does have some unwanted side effects:

  • It makes the ripple/pressed background too small
  • It does not work with "text" buttons

The center-affix also has unwanted side effects:

  • It makes the field single-line which does remove the label

Expected Behavior

Everything should be aligned as in 3.6.11.
If center-affix would not remove the label, this would be a workaround.

Actual Behavior

  • Layout is broken
  • Text-Buttons are aligned to top
  • Ripple/pressed background too small
  • CenterAffix removes the label

Screenshot 2024-07-13 at 14 03 26

Reproduction Link

https://play.vuetifyjs.com/#...
(v-btn style just for better visualisation of ripple/hover background)

Other comments

Could be related to #20064, #20134 and #20154.

@yuwu9145 yuwu9145 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
@mschoeffmann
Copy link
Author

@yuwu9145 Thank you for checking on that. I tested center-affix already but it forces the "single-line" prop (which removes the label).

So, does this mean: Having a centred icon-button inside an append-inner slot and showing the label is not possible any more? Or do you have a hint how to archive this?

Or should I open an issue regarding center-affix not to force single-line (or at least not removing the label).

(example use case: a bunch of v-text-field, readonly, displaying a value and the corresponding label, the slot contains a component with a "copy to clipboard" button)

@yuwu9145
Copy link
Member

@mschoeffmann I had the same pain. bc2f96a has been made on master branch.

So center-affix will only set single-line when it's default null, but showing labels can be enforced by explicitly set single-line to a Boolean false

@mschoeffmann
Copy link
Author

mschoeffmann commented Jul 15, 2024

@yuwu9145 I had the same pain. bc2f96a has been made on master branch.

Great - Thank you very much! I'll check this out with the next release.

@yuwu9145
Copy link
Member

yuwu9145 commented Jul 16, 2024

@mschoeffmann We are going to revert this breaking change #20173, but all changes that were talked about in this thread will be available on dev branch and in a future release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants