We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vuetify: 1.5.4 Vue: 2.6.7 Browsers: Chrome 72.0.3626.119 OS: Mac OS 10.14.0
Please check reproduction link below
v-menu component shouldn't stop click event propagation from its children elements OR it should be configurable
v-menu
v-menu component stops unconditionally click event propagation from its children elements.
https://codepen.io/rogal111/pen/gEPyQM
e.stopPropagation() is called unconditionally on all click events triggered on menu component.
e.stopPropagation()
vuetify/packages/vuetify/src/components/VMenu/mixins/menu-generators.js
Lines 80 to 86 in 67b73b9
It breaks scripts that use event delegation pattern: https://gomakethings.com/why-event-delegation-is-a-better-way-to-listen-for-events-in-vanilla-js/. For example rails ujs uses it: https://github.com/rails/rails/tree/master/actionview/app/assets/javascripts
Here is example: https://codepen.io/rogal111/pen/gEPyQM
The text was updated successfully, but these errors were encountered:
This was added in f154158 and moved in 5be0050, might be safe to remove now. There's also a conflicting feature request #3333.
Sorry, something went wrong.
Was originally added in #417 to fix a bug that is no longer relevant. It also doesn't conflict with the fix for #3333
5af2cd1
johnleider
Successfully merging a pull request may close this issue.
Versions and Environment
Vuetify: 1.5.4
Vue: 2.6.7
Browsers: Chrome 72.0.3626.119
OS: Mac OS 10.14.0
Steps to reproduce
Please check reproduction link below
Expected Behavior
v-menu
component shouldn't stop click event propagation from its children elements OR it should be configurableActual Behavior
v-menu
component stops unconditionally click event propagation from its children elements.Reproduction Link
https://codepen.io/rogal111/pen/gEPyQM
Other comments
e.stopPropagation()
is called unconditionally on all click events triggered on menu component.vuetify/packages/vuetify/src/components/VMenu/mixins/menu-generators.js
Lines 80 to 86 in 67b73b9
It breaks scripts that use event delegation pattern: https://gomakethings.com/why-event-delegation-is-a-better-way-to-listen-for-events-in-vanilla-js/.
For example rails ujs uses it: https://github.com/rails/rails/tree/master/actionview/app/assets/javascripts
Here is example: https://codepen.io/rogal111/pen/gEPyQM
The text was updated successfully, but these errors were encountered: