Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] add prefix to grid classes #7039

Closed
daskyrk opened this issue Apr 22, 2019 · 9 comments
Closed

[Feature Request] add prefix to grid classes #7039

daskyrk opened this issue Apr 22, 2019 · 9 comments
Assignees
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: enhancement Functionality that enhances existing features
Milestone

Comments

@daskyrk
Copy link

daskyrk commented Apr 22, 2019

Problem to solve

If implement the vuetify to an existing project, it's easy to break the original style for vuetify have a set of util style classes, like container, layout or success etc. And it also apply some style to default element like padding in ul > li, which could affect the existing style.

see this problem: https://stackoverflow.com/questions/54293336/how-to-avoid-vuetify-overrides-default-css

Proposed solution

Maybe add a prefix to these util classes and not apply style to default element?

@ghost ghost added the S: triage label Apr 22, 2019
@johnleider
Copy link
Member

I can see this happening for grid but not utilities.

@johnleider johnleider added C: VGrid Covers issues involving VContainer, VLayout, VFlex T: enhancement Functionality that enhances existing features and removed S: triage labels Apr 25, 2019
@daskyrk
Copy link
Author

daskyrk commented Apr 26, 2019

in the cdn file: https://cdn.jsdelivr.net/npm/vuetify/dist/vuetify.min.css, you can format the file with chrome devtool, and there is some style applied to normal element like this:
demo
and some other style starts from line 2734

By the way, class like 'container' is too normal so it's easy to conflict with exist style in project (:

@ipluser

This comment has been minimized.

@KaelWD

This comment has been minimized.

@Dinver
Copy link

Dinver commented Jul 30, 2019

The problem is relevant. In the transition from 1.5 to 2.2. In Vuetify there should be no global styles. Styles should apply only to Vuetify components.
00001
Same with links:
000002

@josvos
Copy link

josvos commented Nov 7, 2019

Just started evaluating Vuetify to see if I can / want to use it in my project and this is the first issue I came across in the first hour: the conflict with my existing container class, adding unwanted padding. It would be great if these generic classes can be renamed with a v- prefix.

@kosmall

This comment has been minimized.

@garbinmarcelo

This comment has been minimized.

@johnleider johnleider added this to the v3.x.x milestone Dec 16, 2020
@johnleider johnleider added the maybe Functionality that we are considering label Dec 16, 2020
@johnleider johnleider changed the title [Feature Request] add prefix to util style classes [Feature Request] add prefix to grid classes Jan 12, 2021
@KaelWD KaelWD modified the milestones: v3.x.x, v3.0.0 Jan 12, 2021
@KaelWD
Copy link
Member

KaelWD commented Jan 12, 2021

This was done for grid classes in #12822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: enhancement Functionality that enhances existing features
Projects
None yet
Development

No branches or pull requests

8 participants