Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Unable to adjust tabs slider height with sass variables #8014

Closed
MatthewAry opened this issue Jul 25, 2019 · 1 comment
Closed
Assignees
Labels
T: bug Functionality that does not work as intended/expected
Milestone

Comments

@MatthewAry
Copy link
Contributor

Environment

Vuetify Version: 2.0.0
Vue Version: 2.6.10
Browsers: Chrome 75.0.3770.142
OS: Mac OS 10.14.5

Steps to reproduce

  • Git clone
  • npm i
  • run server
  • view on web browser

Expected Behavior

Modifying the $tabs-slider-height should change the tab slider element's height to what the variable is set to.

Actual Behavior

The tab slider height is clipped by a parent element because it has a height value of 2px applied through the style property.

Reproduction Link

https://github.com/MatthewAry/vuetify-sass-variables/tree/SliderHeight

Other comments

Related issues: #7683

@ghost ghost added the S: triage label Jul 25, 2019
@johnleider johnleider self-assigned this Jul 25, 2019
@johnleider johnleider added T: bug Functionality that does not work as intended/expected and removed S: triage labels Jul 25, 2019
@johnleider johnleider added this to the v2.0.x milestone Jul 25, 2019
@MatthewAry
Copy link
Contributor Author

I think it would be great to have both the SASS variable and the prop. The SASS variable would set the global slider height and the prop would be an override. Would it be possible to put the variable back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

2 participants