Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Radio-group label seems to be having issues with accesibility #9851

Closed
JohnMica opened this issue Dec 2, 2019 · 3 comments · Fixed by skyYaga/skdvin-webapp#18, skyYaga/skdvin-webapp#21 or anyulled/reactivewebflux#5 · May be fixed by andrebaldo/python-vue-spa-boilerplate#3
Assignees
Labels
C: VRadioGroup VRadioGroup T: bug Functionality that does not work as intended/expected
Milestone

Comments

@JohnMica
Copy link

JohnMica commented Dec 2, 2019

Problem to solve

the label property on a radio-group returns an ID that unfortunately doesnt exists.

  • label prop is created but no ID assigned to it ?
  • aria-labelledby created but the ID doesnt exist on SSR page

Proposed solution

  • update the prop label to become only the aria-label
  • is using a different HTML element as the Label, provide an aria-labellledby that can take a variable / id / etc...
@ghost ghost added the S: triage label Dec 2, 2019
@johnleider johnleider changed the title [Feature Request] Radio-group label seems to be having issues with accesibility [Bug Fix] Radio-group label seems to be having issues with accesibility Jan 15, 2020
@johnleider
Copy link
Member

johnleider commented Jan 15, 2020

According to https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute , aria-label should only be used for labels that are not visible. Also the id issue must have been resolved because I wasn't able to reproduce it.

With that being said, while looking into this I found that v-radio-group was using the incorrect elements for a11y. Also that the label in particular wasn't getting the correct css and didn't have the proper height, breaking margin...basically, it was all jacked up.

This will go out with the next 2.2 patch.

@johnleider johnleider added this to the v2.2.x milestone Jan 15, 2020
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VRadioGroup VRadioGroup and removed S: triage C: VRadio VRadio labels Jan 15, 2020
@johnleider johnleider self-assigned this Jan 15, 2020
@KaelWD
Copy link
Member

KaelWD commented Jan 16, 2020

Related to this commit: #10146, #10214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment