Run Clippy on all CI targets (#2636)

* Run Clippy on all CI targets

* Fix macOS lints

Author: marc0246

.github/workflows/rust.yml

@@ -26,7 +26,7 @@ jobs:
           runs-on: macos-latest
           self-hosted: false
       fail-fast: false
-    name: ${{ matrix.name }}
+    name: build / ${{ matrix.name }}
     runs-on: ${{ matrix.runs-on }}
     steps:
     - uses: actions/checkout@v4
@@ -42,14 +42,29 @@ jobs:
     - name: Build examples
       run: cargo build --profile=CI --verbose --bins
   clippy:
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+        - name: windows-latest
+          runs-on: [self-hosted, Windows]
+          self-hosted: true
+        - name: ubuntu-latest
+          runs-on: ubuntu-latest
+          self-hosted: false
+        - name: macos-latest
+          runs-on: macos-latest
+          self-hosted: false
+      fail-fast: false
+    name: clippy / ${{ matrix.name }}
+    runs-on: ${{ matrix.runs-on }}
     steps:
     - uses: actions/checkout@v4
     - run: rustup toolchain install stable --component clippy
     - uses: Swatinem/rust-cache@v2
+      if: ${{ ! matrix.self-hosted }}
       with:
-        shared-key: ubuntu-latest
-        save-if: "false"
+        shared-key: ${{ matrix.name }}
+        save-if: false
     - name: Run clippy check
       run: cargo clippy --profile=CI -- -Dwarnings
   fmt:

vulkano/src/swapchain/surface.rs

@@ -104,14 +104,14 @@ impl Surface {
             },
             #[cfg(target_vendor = "apple")]
             (RawWindowHandle::AppKit(handle), _) => {
-                let layer = raw_window_metal::Layer::from_ns_view(handle.ns_view);
+                let layer = unsafe { raw_window_metal::Layer::from_ns_view(handle.ns_view) };
 
                 // Vulkan retains the CAMetalLayer, so no need to retain it past this invocation
                 unsafe { Self::from_metal(instance, layer.as_ptr().as_ptr(), None) }
             }
             #[cfg(target_vendor = "apple")]
             (RawWindowHandle::UiKit(handle), _) => {
-                let layer = raw_window_metal::Layer::from_ui_view(handle.ui_view);
+                let layer = unsafe { raw_window_metal::Layer::from_ui_view(handle.ui_view) };
 
                 // Vulkan retains the CAMetalLayer, so no need to retain it past this invocation
                 unsafe { Self::from_metal(instance, layer.as_ptr().as_ptr(), None) }