Incorrect use of deprecated attribute

[estebank]

rust-lang/rust#56896 is making the correct use of deprecated mandatory in rustc. We can't apply this as a hard error due to the following use in vk-sys:

[INFO] [stderr]     Checking vk-sys v0.2.7
[INFO] [stderr]     Checking vk v0.0.1
[INFO] [stderr]    Compiling spirv-utils v0.2.1
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:918:1
[INFO] [stderr]     |
[INFO] [stderr] 918 | #[deprecated = "Renamed to COLOR_SPACE_SRGB_NONLINEAR_KHR"]
[INFO] [stderr]     | ^^--------------------------------------------------------^
[INFO] [stderr]     |   |
[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = "Renamed to COLOR_SPACE_SRGB_NONLINEAR_KHR")`
[INFO] [stderr] 
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:920:1
[INFO] [stderr]     |
[INFO] [stderr] 920 | #[deprecated = "Magically disappeared from the Vulkan specs"]
[INFO] [stderr]     | ^^----------------------------------------------------------^
[INFO] [stderr]     |   |
[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = "Magically disappeared from the Vulkan specs")`
[INFO] [stderr] 
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:922:1
[INFO] [stderr]     |
[INFO] [stderr] 922 | #[deprecated = "Magically disappeared from the Vulkan specs"]
[INFO] [stderr]     | ^^----------------------------------------------------------^
[INFO] [stderr]     |   |
[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = "Magically disappeared from the Vulkan specs")`
[INFO] [stderr] 
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:924:1
[INFO] [stderr]     |
[INFO] [stderr] 924 | #[deprecated = "Magically disappeared from the Vulkan specs"]
[INFO] [stderr]     | ^^----------------------------------------------------------^
[INFO] [stderr]     |   |
[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = "Magically disappeared from the Vulkan specs")`
[INFO] [stderr] 
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:926:1
[INFO] [stderr]     |
[INFO] [stderr] 926 | #[deprecated = "Magically disappeared from the Vulkan specs"]
[INFO] [stderr]     | ^^----------------------------------------------------------^
[INFO] [stderr]     |   |
[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = "Magically disappeared from the Vulkan specs")`
[INFO] [stderr] 

[rukai]

The error you have posted is for vk-sys 0.2.7 which is much older than the current release of 0.4.0.
I suspect something is using an older version of vk-sys as a dependency here, so not much I can do in this specific case. Looks like you've already decided to change it to a warning, which is good because that's clearly the only way to not break everything here.

However the issue still exists in current vulkano so I'll fix it there. PR incoming.