-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it ok for Vulkano-shaders to depend on Vulkano? #1693
Comments
@Rua I think that's fine. But can you please outline what particular changes are you going to do? The thing is I'm currently working on some Vulkano-shaders improvements too. |
There is no hurry though, I haven't done any work yet so I'll wait for you to finish. |
@Rua ok, sounds good. Just to let you know that I'm currently working on extension of vulkano-shaders to compile several sources at once producing independent generated layout per each source, but keeping all their structs in a single shareable generated |
@AustinJ235 @Eliah-Lakhin I would like to start moving some of the code in Vulkano-shaders to the main Vulkano crate, so that it can be used both by runtime-loaded shaders and shaders compiled with Vulkano-shaders. But to avoid duplication, Vulkano-shaders would need to be able to import some of these items from the main crate. It currently lists Vulkan only as a dev-dependency, but I would like to upgrade this to a full dependency. This would mean that Vulkano-shaders can't be used without Vulkano anymore, but I think that's ok because it outputs Vulkano-specific code anyway and wouldn't be particularly useful without it.
The text was updated successfully, but these errors were encountered: