Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of shader interface matching is insufficient #1738

Closed
Rua opened this issue Oct 26, 2021 · 2 comments · Fixed by #2418
Closed

Validation of shader interface matching is insufficient #1738

Rua opened this issue Oct 26, 2021 · 2 comments · Fixed by #2418

Comments

@Rua
Copy link
Contributor

Rua commented Oct 26, 2021

Vulkano currently checks whether the interfaces of two shaders match, by checking that the values written to each interface location are the same. But the Vulkan spec has a stronger requirement, as described here. There is only a match if the types of the two variables, as defined with SPIR-V opcodes, match. It is possible for two shaders to have the same interface location representation but different actual types, so the current check in Vulkano seems to be not strict enough.

@VictorBulba
Copy link
Contributor

VictorBulba commented Oct 27, 2021

In addition, can shader validation api be exposed to the user? It it very useful for those who write their own engines

@Rua
Copy link
Contributor Author

Rua commented Oct 27, 2021

That's issue #1558, which I definitely haven't forgotten about. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants