Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No examples of how to use CpuBufferPool #1850

Closed
Firstyear opened this issue Feb 27, 2022 · 3 comments
Closed

No examples of how to use CpuBufferPool #1850

Firstyear opened this issue Feb 27, 2022 · 3 comments

Comments

@Firstyear
Copy link

It would be good to have simple examples of how to use CpuBufferPool to get data from a computation.
@bits0rcerer
Copy link

bits0rcerer commented Nov 27, 2022 •
edited
Loading

Might be related to #867

@Rua
Copy link
Contributor

Rua commented Jan 12, 2023

CpuBufferPool no longer exists, so this issue is moot.

@Rua Rua closed this as completed Jan 12, 2023
@Enyium
Copy link

Enyium commented Feb 21, 2023

@Rua: I wanted to chime in before you release a modified API and say that CpuBufferPool::from_data() and CpuBufferPool::from_iter() weren't named according to convention. You would expect that these functions return a CpuBufferPool, not a CpuBufferPoolSubbuffer. The Rust API Guide indicates the following about these so called conversion constructors, which are without self parameter: ThisType::from_some_other_type().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Firstyear @Rua @bits0rcerer @Enyium