Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when source is too small for ImmutableImage #2022

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Better error message when source is too small for ImmutableImage #2022

merged 2 commits into from
Oct 6, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Oct 4, 2022

After discussion on Discord, this provides the user with a better error message if the source data is too small for the image they're trying to create.

AustinJ235
AustinJ235 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AustinJ235 AustinJ235 merged commit de920e4 into vulkano-rs:master Oct 6, 2022
@Rua Rua deleted the immutableimage-error branch December 6, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @AustinJ235