Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBJString node #626

Open
mhusinsky opened this issue Apr 6, 2023 · 1 comment
Open

OBJString node #626

mhusinsky opened this issue Apr 6, 2023 · 1 comment

Comments

@mhusinsky
Copy link

mhusinsky commented Apr 6, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Sometimes it is helpful to not only write an OBJ object to disk as a file, but have it available as a string (e.g. for network transmission). The OBJWriter node does currently do everything conversion related but forces you to write the result to disk.

Describe the solution you'd like
I'd suggest an additional OBJString node that does exactly what the OBJWriter node does, but provides the result as a string output.

Additional context
I can provide a PR if the idea is proven worthy. (can be done together with #625 )
@joreg
Copy link
Member

joreg commented Apr 11, 2023

sounds good. we'll accept a PR for this. the nodes as they are now should then also be built with those new string nodes. please document your PR with screenshots and a good description to simplify the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joreg @mhusinsky