Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use GitLab references without prefix #114

Open
sleeyax opened this issue Feb 5, 2024 · 3 comments
Open

Unable to use GitLab references without prefix #114

sleeyax opened this issue Feb 5, 2024 · 3 comments
Labels
pull request welcome A pull request is welcome

Comments

@sleeyax
Copy link

sleeyax commented Feb 5, 2024

Not sure what I'm doing wrong but I have the following in package.json:

"hallmark": {
    "autolinkReferences": {
      "prefix": "#",
      "url": "https://gitlab.com/company/project/-/issues/<num>"
    }
  }

And added the following entry:

## [0.0.1] - 2024-02-05

### Changed

### Added

- Add feature (#1)

### Removed

### Fixed

Then hallmark fix generates the following:

## [0.0.1] - 2024-02-05

### Changed

### Added

- Add feature ([#1](https://github.com/company/project/issues/1))

### Removed

### Fixed

As you can see, the link should be to gitlab.com but it's generating a link pointing to github.com instead.

@vweevers
Copy link
Owner

vweevers commented Feb 5, 2024

That plugin relies on prefixes like JIRA-123, GH-123, GL-123, rather than a hash. The #123 syntax is reserved for GitHub atm and handled by a different plugin (which causes the above output).

@sleeyax
Copy link
Author

sleeyax commented Feb 5, 2024

Oh that's too bad. Is it possible at all to configure # to apply gitlab instead? I don't use GitHub for this project.

@vweevers
Copy link
Owner

vweevers commented Feb 5, 2024

Not currently. I see that remark-github has a buildUrl option that we can maybe use to override the github.com domain. We'd also need an option on this end (or maybe detect the use of GitLab by repository info in package.json).

@vweevers vweevers changed the title Hallmark config not working Unable to use GitLab references without prefix Feb 5, 2024
@vweevers vweevers added the pull request welcome A pull request is welcome label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request welcome A pull request is welcome
Projects
None yet
Development

No branches or pull requests

2 participants