Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on README #53

Closed
FelipeMartins96 opened this issue Sep 14, 2021 · 2 comments
Closed

Broken links on README #53

FelipeMartins96 opened this issue Sep 14, 2021 · 2 comments

Comments

@FelipeMartins96
Copy link
Contributor

Problem Description

Broken links on Algorithms Implemented section of README

Current Behavior

Links are pointing to unavailable pages

Expected Behavior

Link should point to desired code

Possible Solution

Remove links to removed code or change links to new location

Steps to Reproduce

The link to the following codes on README implemented algorithms section are pointing to old locations, resulting in page 404:

experiments/ppo_self_play.py
experiments/ppo_microrts.py
experiments/ppo_simple.py
experiments/ppo_simple_continuous_action.py

not sure if there are more links, i found these one as they are on the experiments folder which does not exist anymore

@vwxyzjn
Copy link
Owner

vwxyzjn commented Sep 14, 2021

Hey @FelipeMartins96 thanks for reporting the problem. Yeah those links are broken due to some cleaning up. Would you mind making a PR removing the references to these links?

@FelipeMartins96
Copy link
Contributor Author

sure! Will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants