Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packer: T6390: Compensate for packer packaging update #633

Merged
merged 1 commit into from
May 29, 2024

Conversation

cjac
Copy link

@cjac cjac commented May 22, 2024

packer: T6390: Compensate for packer packaging update

new packer zip file comes with license as well as the packer binary.
compensate for this while not breaking old code

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, long time no see!

We don't use Packer ourselves, but if it fixes the process for those who do, I have nothing against the fix.

@cjac
Copy link
Author

cjac commented May 23, 2024

Hey there!

Then I'll clean it up a bit today.

@sever-sever
Copy link
Member

@cjac Could you create a task on https://vyos.dev/ and add the task number to the commit message and PR header?
More details
https://github.com/vyos/vyos-1x/blob/current/CONTRIBUTING.md
https://blog.vyos.io/pull-request-creation-guidelines

@cjac
Copy link
Author

cjac commented May 23, 2024

I'd be happy to. Please give me until about noon. The kiddo is sick and needs some attention first.

@cjac
Copy link
Author

cjac commented May 23, 2024

https://vyos.dev/T6390

@cjac
Copy link
Author

cjac commented May 23, 2024

My docker build shows that this updated RUN command succeeds

@cjac
Copy link
Author

cjac commented May 23, 2024

Full docker build succeeds. I approve of this change.

 => [66/67] RUN echo -e "set mouse=\nset ttymouse=" > /etc/vim/vimrc.loca  0.5s
 => [67/67] COPY entrypoint.sh /usr/local/bin/entrypoint.sh                0.1s
 => exporting to image                                                     7.8s
 => => exporting layers                                                    7.7s
 => => writing image sha256:a908bd97d1339c0984d448121a2bb15ee93edef573709  0.0s
 => => naming to docker.io/vyos/vyos-build:equuleus                        0.0s

@sever-sever
Copy link
Member

every change must be associated with a task number
(prefixed with T) and a component. If there is no bug report/feature
request for the changes you are going to make, you have to create a development portal
task first. Once there is an entry in the development portal, you should reference its id
in your commit message, as shown below:

  • ddclient: T1030: auto create runtime directories

@sever-sever sever-sever requested review from a team, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team May 23, 2024 16:58
@cjac cjac changed the title new packer comes with license as well as the packer binary packer: T6390: Compensate for packer packaging update May 28, 2024
@cjac
Copy link
Author

cjac commented May 28, 2024

@sever-sever - PR message updated. Please review.

@sever-sever
Copy link
Member

@sever-sever - PR message updated. Please review.

The commit message is not fixed
commit-message

new packer zip file comes with license as well as the packer binary.
compensate for this while not breaking old code
@cjac cjac requested a review from a team as a code owner May 28, 2024 20:42
@github-actions github-actions bot added the equuleus VyOS 1.3 LTS label May 28, 2024
@cjac
Copy link
Author

cjac commented May 28, 2024

okay. commit message amended in addition to the PR message.

@c-po c-po merged commit b3da0d4 into vyos:equuleus May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
equuleus VyOS 1.3 LTS
Development

Successfully merging this pull request may close these issues.

4 participants