T6231: MFT debs #777
T6231: MFT debs #777
Conversation
Per comment by Nicolas Vollmar - MFT userspace tools are needed by some of the MLX functionality. Add download and unpack directives to the OFED build script which should pull and extract the Debian package from MLX/NV's site into the current working directory which will contain the built DEBs after completion of the script for inclusion into the image build. Testing: None yet, quickly put together to address user comment, would apperciate QA by someone who has time as i wont be able to do this until the weekend at the earliest.
sempervictus
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
nicolas-fort
|
👍 |
|
I'm doing a test run with those changes |
|
The code added works, but ends up with the deps in Currently I fail building the image at |
There was a problem hiding this comment.
Jenkins is deprecated, use please this path for changes https://github.com/vyos/vyos-build/blob/current/scripts/package-build/linux-kernel/build-mellanox-ofed.sh
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Humbug, I'm lagging on reviews; apologies. Any idea what I should be using for owner and permissions on the deb? |
|
the other built packages belong to root:root. |
There was a problem hiding this comment.
Folks, it looks like we simply cannot include that package in our images — that would violate the Mellanox EULA!
Here is the relevant part of LICENSE.txt included in the tarball:
1. General
Each copy of the Software is intended for use only in conjunction
with Mellanox’s hardware products (“Mellanox Products”)
and is subject to the terms of this Agreement.
2. Grant of License
Subject to the terms and conditions of this Agreement, Mellanox
grants you a personal, non-exclusive, non-transferable license
to use, view, copy, print, and distribute software and
accompanying documentation subject to the following conditions:
(i) The Software and any accompanying documentation may
be used solely to support Mellanox Products;
(ii)You may distribute the Software and accompanying documentation
solely as integrated with or installed on Your products that
incorporate the Mellanox Products.
After "resolving macros", that's:
You may distribute the Software and accompanying documentation
solely as integrated with or installed on Your products that incorporate Mellanox's hardware products.
As I understand it, it's only legal to redistribute the package in an OS preinstalled (or at least meant for) hardware boxes that include Mellanox cards in them. Distributing them in a general-purpose OS that is meant to run on boxes that don't have any Mellanox hardware in them would violate those conditions.
|
I got a confirmation from the legal team about the concerns — this PR would indeed violate the Mellanox EULA and cannot be merged. |
|
What does Nvidia themselves say about that? I interpret that as the software from Nvidia can only be used with Nvidia products which is kind of obvious since a Intel driver for lets say igb doesnt work with any other NIC. Another workaround could perhaps be to add this as a VyOS module/package that could be installed afterwards by the admin in case this cannot be part of the ISO itself? |
|
Currently they can't even be manually installed because the ISO is lacking some dependencies needed by the OFED driver packages. |
Per comment by Nicolas Vollmar - MFT userspace tools are needed by some of the MLX functionality.
Add download and unpack directives to the OFED build script which should pull and extract the Debian package from MLX/NV's site into the current working directory which will contain the built DEBs after completion of the script for inclusion into the image build.
Testing:
None yet, quickly put together to address user comment, would
apperciate QA by someone who has time as i wont be able to do this until the weekend at the earliest.
Change Summary
Types of changes
Related Task(s)
Component(s) name
Proposed changes
How to test
Checklist: