Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for nan 2.0 API changes (io.js 3.x - node.js 4.0) #93

Closed
leodutra opened this issue Aug 27, 2015 · 5 comments
Closed

Update for nan 2.0 API changes (io.js 3.x - node.js 4.0) #93

leodutra opened this issue Aug 27, 2015 · 5 comments

Comments

@leodutra
Copy link

nan was updated to 2.0 and supports V8 changes in io.js 3.x.

This new API will be determinant for node.js 4.0
@bzuillsmith
Copy link

Yep, just need someone to get it compiling with 2.0.

@deckar01 deckar01 mentioned this issue Sep 11, 2015
Closed
@leodutra
Copy link
Author

Temporary fix: restrict supported node engine on package.json (deckar01@24b4e0b).

@wankdanker
Copy link
Collaborator

Just released odbc@1.2.0 which compiles and passes tests with current nan and node@0.8.28, node@0.10.40, node@0.12.7, node@4.0.0, node@4.1.0, node@4.1.1 but has not been extensively tested for memory leaks or things of that nature.

@leodutra
Copy link
Author

A whole day running SQL on BlazingSquirrel web SQL client.

No signal of memory leaks serving on Ubuntu 14.04.3 with IBM DB2 CLI Driver 10.x. And I'm talking about more than 10 million registers at least.

Awesome, Dan.

@wankdanker
Copy link
Collaborator

Awesome. Glad to hear it!

clach04 referenced this issue in clach04/node-odbc__DO_NOT_USE Dec 17, 2020
@markdirish
2.3.0 fix actions (wankdanker#93)
86a647f 
* Retool the build process and binding process to use node-pre-gyp's N-API support
* Update .gitignore for new build artifacts
* Change default npm install script

Signed-off-by: Mark Irish <mirish@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leodutra @wankdanker @bzuillsmith