-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make explicit that there can be multiple state machine keys for a particular RP #388
Comments
The keys in the state machine are already a triple |
I will admit my concern is informed with working with UX teams and assumptions that can be made. I felt the explicit part was more to communicate to a non-implementer that there should be more than one allowed IdP per RP (as well as more than one allowed account per IdP per RP). I am unfamiliar with W3C spec conventions: perhaps my concern is better supported in other documentation. |
Oh ok! I think specs are mostly meant for implementers although they are also looked at by other people. For developers or other people, I'd recommend looking at developer docs instead. For FedCM one such example is https://developer.chrome.com/docs/privacy-sandbox/fedcm/#use-api. But perhaps we can add a note (doesn't hurt?) |
After writing the PR for this issue, I'm not really convinced that we need a note. It should be clear that a user may have more than one 'registered' account from the shape of the state machine. So I think we should close this issue, is that reasonable to you? |
Yes, my regrets for causing churn. |
While this may be "obvious" i suggest an explicit statement that prevents differing interpretations in the future.
I suggest text along the lines of:
There are many usecases where an individual may use (register) multiple IdPs with a single RP:
Note that this is not exactly like https://github.com/fedidcg/FedCM/issues/319 which appears to focus on the RP indicating multiple IdPs are acceptable. This follows on that issue by clarifying that given a set of IdPs accepted by an RP, a end user may use more than one and should NOT be required to "deregister" an IdP relationship with an RP before registering a second IdP with that RP.
The text was updated successfully, but these errors were encountered: