Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking clarity on name property with div #202

Closed
howard-e opened this issue Sep 27, 2023 · 5 comments
Closed

Seeking clarity on name property with div #202

howard-e opened this issue Sep 27, 2023 · 5 comments
Assignees
Labels

Comments

@howard-e
Copy link

This relates to a new wpt test being added for comp_tooltip, with web-platform-tests/wpt#42093.

<div title="label" data-expectedlabel="label" data-testname="div with text with tooltip label" class="ex">content</div>

@cookiecrook review comment states:

This div test may be ambiguous since its role is undefined and should in theory be "", generic, or none, which don't support name from: author or contents. Adding role="group" should remove the ambiguity IIRC.

We're seeking clarity on if there is a spec ambiguity here.

@cookiecrook
Copy link
Contributor

cookiecrook commented Sep 27, 2023

ARIA spec defines Name From: prohibited on both none and generic...
So should new tests verify the name is empty "" (not "title" or "content")?

@jnurthen
Copy link
Member

No. This is an authoring requirement not a user agent requirement. We deliberately have not made this a UA requirement to avoid breaking the web

@cookiecrook
Copy link
Contributor

I assume that means we should just continue to not test computedlabel on generics? Howard's test has been updated to avoid that (explicitly role="group" now), so there is nothing to be done, unless we want to document this decision somewhere in the WPT repo.

@cookiecrook
Copy link
Contributor

I'll close once I determine if there is more to do re: documenting this in the WPT source.

@cookiecrook
Copy link
Contributor

cookiecrook commented Oct 7, 2023

I think we’re good without a WPT source change or comment. If ambiguities or bugs sneak back in to the tests, we can always fix them. @howard-e please merge the related test when you are ready. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants