Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-preview hides mapping tables in CORE-AAM and HTML-AAM previews #53

Open
carmacleod opened this issue Jan 4, 2021 · 0 comments
Open

Comments

@carmacleod
Copy link
Contributor

carmacleod commented Jan 4, 2021

pr-preview hides the mapping tables in all CORE-AAM and HTML-AAM PR previews (maybe also in other AAM specs - didn't check).
Since mapping tables are a key feature of AAM specs, this is an unfortunate omission.

I suspect that the problem is somewhere in aria-common/script/mapping-tables.js (presumably in one of the places where the .table-container is told to .hide(), for example, $(this).hide(); ), and I suspect that the issue may have something to do with deprecated ReSpec events. I don't know how to debug and test pr-preview without creating fake PR(s), which would send everyone a bunch of "debug code" notifications. 😄

Note that the tables are actually in the preview - they're just hidden. You can get them to show up by going into devtools and removing style="display: none;" from each element that has class="table-container", but this is not something that most people guess when they are simply reviewing a PR, so it is an unfortunate source of confusion and a potential time sink for reviewers.

Not sure if this issue is related to: #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant