Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox with dialog: is the dialog necessarily modal? #1215

Closed
0ddfell0w opened this issue Oct 18, 2019 · 2 comments
Closed

Combobox with dialog: is the dialog necessarily modal? #1215

0ddfell0w opened this issue Oct 18, 2019 · 2 comments
Labels
Pattern Page Related to a page documenting a Pattern question Issue asking a question

Comments

@0ddfell0w
Copy link

0ddfell0w commented Oct 18, 2019

Should I extrapolate from the following quotations that combobox dialogs need to be modal, or is it only that the keyboard interactions (e.g. trapping focus) are the same as for modal dialogs?

The dialog implements the keyboard interaction defined in the modal dialog pattern.
-APG Combobox

and

The roles, states, and properties for popup elements are defined in their respective design patterns [...] Dialog Roles, States, and Properties

(where the link takes you to the states and properties expected of modal dialogs, including aria-modal)

Is there an expectation that the rest of the page will be inert when the dialog is expanded? Or would a non-modal dialog (#59 ) be appropriate? I understand there might be some hard to avoid ambiguity due to the non-modal dialog pattern is not complete.

@0ddfell0w 0ddfell0w changed the title Combobox with dialog: is the dialog modal? Combobox with dialog: is the dialog necessarily modal? Oct 18, 2019
@0ddfell0w
Copy link
Author

Given this note in the Dialog states and properties section, it would seem very opinionated to suggest that combobox dialogs should be modal

NOTE
Because marking a dialog modal by setting aria-modal to true can prevent users of some assistive technologies from perceiving content outside the dialog, users of those technologies will experience severe negative ramifications if a dialog is marked modal but does not behave as a modal for other users. So, mark a dialog modal only when both:
Application code prevents all users from interacting in any way with content outside of it.
Visual styling obscures the content outside of it.
The aria-modal property introduced by ARIA 1.1 replaces aria-hidden for informing assistive technologies that content outside a dialog is inert. However, in legacy dialog implementations where aria-hidden is used to make content outside a dialog inert for assistive technology users, it is important that:
aria-hidden is set to true on each element containing a portion of the inert layer.
The dialog element is not a descendant of any element that has aria-hidden set to true.

@mcking65
Copy link
Contributor

Should I extrapolate from the following quotations that combobox dialogs need to be modal, or is it only that the keyboard interactions (e.g. trapping focus) are the same as for modal dialogs?

Only the keyboard behavior of trapping.

You are right that it would be far too opinioniated to suggest that comboboxes only open true modals. And, it would help if we had the non-modal pattern and examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern Page Related to a page documenting a Pattern question Issue asking a question
Projects
None yet
Development

No branches or pull requests

2 participants