Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs widget has aria-controls attributes that point to hidden elements #293

Closed
ZoeBijl opened this issue Feb 17, 2017 · 2 comments
Closed
Assignees
Labels
invalid Closed primarily due to error or inaccuracy of some kind

Comments

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Feb 17, 2017

You can’t control something that isn’t visible. aria-controls should only be added to role=tabs that have aria-selected=true.

Related conversation on Twitter
Related issue against the ARIA spec

@ZoeBijl ZoeBijl self-assigned this Feb 17, 2017
@ZoeBijl ZoeBijl added the bug Code defects; not for inaccurate prose label Feb 17, 2017
@mcking65
Copy link
Contributor

mcking65 commented Feb 17, 2017

@MichielBijl wrote:

You can’t control something that isn’t visible.  aria-controls  should only be added to  role=tab s that have  aria-selected=true .

Completely disagree! You are controlling the visibility!

This is not a bug. We should not change the examples of tabs because the example conforms with the spec. There are very good reasons for leaving the spec as is. See my comments in issue w3c/aria#531.

This idea does not scale. Imagine applying this rule at scale and across other relationships, e.g., aria-owns, using the same rationale. This would create perf problems and all kinds of ridiculousness.

As I described in issue 531, there are other ways of addressing the concerns raised by @LJWatson.

I am removing the bug label and marking this issue invalid. If consensus forms in support of such an authoring requirement in ARIA issue 531, we'll reflag it as a bug and put in a milestone that coincides with the ARIA change.

We need to keep the authoring practices consistent with the task force consensus understanding of the ARIA specification. We should only make exceptions if there is consensus in the ARIA working group that the specification itself has a defect.

@mcking65 mcking65 added invalid Closed primarily due to error or inaccuracy of some kind and removed bug Code defects; not for inaccurate prose labels Feb 17, 2017
@ZoeBijl
Copy link
Contributor Author

ZoeBijl commented Feb 17, 2017

I am removing the bug label and marking this issue invalid. If consensus forms in support of such an authoring requirement in ARIA issue 531, we'll reflag it as a bug and put in a milestone that coincides with the ARIA change.

Sounds good. Am closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Closed primarily due to error or inaccuracy of some kind
Development

No branches or pull requests

2 participants