Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "currently open" view also shows closed (unmerged) PRs #276

Open
pchampin opened this issue Jan 27, 2025 · 2 comments
Open

The "currently open" view also shows closed (unmerged) PRs #276

pchampin opened this issue Jan 27, 2025 · 2 comments

Comments

@pchampin
Copy link

E.g., it currently shows, e.g

This may be related (?) to the fact that did-spec was renamed (some time ago) to did-core.
(For completeness, the same repo was renamed again recently to did, even though I don't think that that last renaming can have anything to do with this issue)

@deniak
Copy link
Member

deniak commented Jan 27, 2025

Unfortunately these PRs are too old to debug why they weren't properly closed in the repo manager.
I'm pretty sure a lot of the PRs listed have been closed and they haven't recorded them as such.
I don't think it's a big problem as long as the PR was merged with the right commitments but I'm leaving that issue open to see how we can review all these PRs are update their state if necessary.

@dontcallmedom
Copy link
Member

more generally, I think we should have the tool check updated states of PRs it knows of on a regular basis, and we should clarify how we want to handle PRs that no longer exist for a reason or another (see also #271 re PR state monitoring)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants